use oncecell to store computed start_pos instead of storing it on shorter-lived CursorData#10
Merged
sunshowers merged 6 commits intosunshowers-code:mainfrom Apr 19, 2023
Conversation
…g it on shorter-lived CursorData
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 82.71% 82.68% -0.04%
==========================================
Files 7 7
Lines 677 693 +16
==========================================
+ Hits 560 573 +13
- Misses 117 120 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sunshowers
reviewed
Apr 19, 2023
Cargo.toml
Outdated
| [dependencies] | ||
| bytes = "1.3.0" | ||
| futures-io-03 = { package = "futures-io", version = "0.3.25", optional = true } | ||
| once_cell = "1.17" |
Contributor
There was a problem hiding this comment.
Probably going to have to reduce the version requirement here because we advertise support against pretty old versions of rustc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.